fix incorrect address being printed in fastbin_dup_into_stack#206
Merged
Kyle-Kyle merged 1 commit intoshellphish:masterfrom Apr 25, 2025
Merged
Conversation
note that the assert at the end of the file is correct so this is really just an issue with the address that is printed i've also increased the size of stack_var to match what is logically being used note that a patch was made in 0a3ba05 fixing this issue however the patch only fixed the issue for glibc_2.35 when it should have been applied to versions 2.33 -> 2.39
Contributor
Author
|
just to reiterate this is really just applying this patch 0a3ba05 through 2.33 to 2.39 as it should originally have been that was my mistake originally btw (oops sorry) |
Contributor
Author
|
for a bit of extra context here is the original pr #168 |
Contributor
|
This PR is great! Sorry for the late response. Was crazily busy recently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
note that the assert at the end of the file is correct so this is really just an issue with the address that is printed
i've also increased the size of stack_var to match what is logically being used
note that a patch was made in 0a3ba05 fixing this issue
however the patch only fixed the issue for glibc_2.35 when it should have been applied to versions 2.33 -> 2.39